Re: PATCH: Further aacraid work

From: Christoph Hellwig
Date: Wed Jun 16 2004 - 16:48:10 EST


On Wed, Jun 16, 2004 at 05:40:48PM -0400, Alan Cox wrote:
> > Looks mostly good except for the GART iommu ifdef. That code is bogus for
> > almost everything but a plain PC and should just be killed.
>
> There are lots of problems with the PC centric view of the world some
> aacraid hardware has. At the moment I'm still working on trying to understand
> the rules and I'll need to talk to Mark some more. I've also got a third
> party trace suggesting a request for low DMA memory came in through the
> gart which is above the address in the mask to look at.
>
> Its something I hope to get rid of eventually. In the meantime the GART
> define is needed to make it work on AMD64.

Well, the code is completely wrong. It must not only go away for AMD64 but
for all arches.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/