Re: [ACPI] [patch] 2.6.7-rc2-mm1: let SERIAL_8250_ACPI depend on ACPI_PCI

[Matthew Wilcox]

On Wed, Jun 02, 2004 at 02:39:39AM +0200, Adrian Bunk wrote:
>   CC      drivers/serial/8250_acpi.o
> drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
> drivers/serial/8250_acpi.c:61: warning: implicit declaration of function `acpi_register_gsi'
> 
> It seems the following is required:
> 
>  config SERIAL_8250_ACPI
>  	bool "8250/16550 device discovery via ACPI namespace"
>  	default y if IA64
> -	depends on ACPI_BUS && SERIAL_8250
> +	depends on ACPI_PCI && SERIAL_8250
>  	---help---

Hmm.  It's *morally* wrong since there's really no requirement that
a machine with ACPI serial should have PCI ... but on the other hand,
we're unlikely to see a machine without PCI that requires us to discover
ACPI serial ports.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/