Re: [PATCH] active_load_balance() deadlock

From: Linus Torvalds
Date: Tue Jun 01 2004 - 15:21:19 EST




On Tue, 1 Jun 2004, Bjorn Helgaas wrote:
>
> active_load_balance() looks susceptible to deadlock when busiest==rq.
> Without the following patch, my 128-way box deadlocks consistently
> during boot-time driver init.

Makes sense. The regular "load_balance()" already has that test, although
it also makes it a WARN_ON() for some unexplained reason (I assume
find_busiest_group() isn't supposed to find the local group, although it
doesn't seem to be documented anywhere).

Ingo, Andrew?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/