Re: [PATCH] Fix typo in pmac_zilog

[Benjamin Herrenschmidt]

On Mon, 2004-05-31 at 10:32, David S. Miller wrote:
> On Sun, 30 May 2004 17:13:38 +1000
> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > There is a deadlock issue. I triggered once when I had a bug where the
> > driver was flooding the input with zero's. All serial drivers seem to be
> > affected. Apparently, tty_flip_* may call back into your write() routine
> 
> Yes indeed, one code path is:
>
> .../...

Yup, another one is when echo is enabled, you may call back into write.

> It seems lots of serial drivers have this bug, even 8250.c :-)

Yes, I told Russell about it.

> I'll fix up the Sparc drivers meanwhile.
-- 
Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/