[patch] Re: Gigabit Kconfig problems with yesterday's update

[Adrian Bunk]

On Sat, May 29, 2004 at 07:51:41AM -0700, walt wrote:

> I have one machine with a gigabit NIC which I updated today from Linus'
> bk tree.
> 
> The problem is that I was not asked if I wanted the 'new' gigabit
> support and therefore the tg3 support was dropped from my new .config.
> 
> I edited .config by hand and deleted any mention of ethernet support --
> and only then did 'make oldconfig' ask me the right questions.
> 
> Also: the phrase (10 or 100Mbit) should be deleted from the 'Ethernet'
> menu item since it implies (wrongly) that the item is not needed for
> gigabit support.

Thanks for this good report (and I'm now understanding the issue without 
requiring your .config).

@Jeff:
At a first glance, it seems the patch below that simply removes the 
dependency of NET_GIGE on NET_ETHERNET would suffice.

Is this correct or did I miss something?

> Thanks!

cu
Adrian

--- linux-2.6.7-rc2-full/drivers/net/Kconfig.old	2004-05-30 15:33:24.000000000 +0200
+++ linux-2.6.7-rc2-full/drivers/net/Kconfig	2004-05-30 15:38:41.000000000 +0200
@@ -1879,7 +1879,7 @@
 
 config NET_GIGE
 	bool "Gigabit Ethernet (1000/10000 Mbit) controller support"
-	depends on NETDEVICES && NET_ETHERNET && (PCI || SBUS)
+	depends on NETDEVICES && (PCI || SBUS)
 	help
 	  Gigabit ethernet.  It's yummy and fast, fast, fast.
 

-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html