Re: nfsd oops 2.6.7-rc1

[Neil Brown]

On Friday May 28, wli@xxxxxxxxxxxxxx wrote:
> While idle, the following oops happened. On virgin 2.6.7-rc1.
> 

Ok, I think I've found it.  There is a missing dget.  See below/.
NeilBrown

=====================================================
Another missing dget

The recentish change to fh_compose not consuming a reference
to the passed dentries missed this needed dget.

Signed-off-by: Neil Brown <neilb@xxxxxxxxxxxxxxx>

 ----------- Diffstat output ------------
 ./fs/nfsd/vfs.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff ./fs/nfsd/vfs.c~current~ ./fs/nfsd/vfs.c
--- ./fs/nfsd/vfs.c~current~	2004-05-29 13:21:19.000000000 +1000
+++ ./fs/nfsd/vfs.c	2004-05-29 13:21:36.000000000 +1000
@@ -899,7 +899,7 @@ nfsd_create(struct svc_rqst *rqstp, stru
 			goto out;
 	} else {
 		/* called from nfsd_proc_create */
-		dchild = resfhp->fh_dentry;
+		dchild = dget(resfhp->fh_dentry);
 		if (!fhp->fh_locked) {
 			/* not actually possible */
 			printk(KERN_ERR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/