Re: [PATCH][RFC] 2.6.6 tty_io.c hangup locking

From: Jurjen Oskam
Date: Fri May 28 2004 - 15:14:57 EST


On Fri, May 28, 2004 at 01:42:50PM -0500, Paul Fulghum wrote:

> Up to now, this did not cause any actual problems.
> In 2.6.X this causes a warning if any of the called functions
> (flush_buffer/write_wakeup) call spin_xxx_bh() functions.

It was not only a warning here, but the pptp client also didn't work again
until after rebooting. Every time the connection was retried (every 10
seconds or so) the message appeared. Perhaps this is a problem in the pptp
client, but after rebooting it worked.

As for the patch: applied to vanilla 2.6.5 (applied cleanly, offset -5
lines) and compiling now.

One problem though: I'm running 2.6 for about two weeks now (with a 24x7
pptp connection), and I encountered this problem just once. I've seen a
report that someone got this error when his connection was severed, so
I'll try to pull the phone cable a few times and see how it recovers, both
with and without your patch. I'll report back when I know more.

Thanks,
--
Jurjen Oskam

"Avoid putting a paging file on a fault-tolerant drive, such as a mirrored
volume or a RAID-5 volume. Paging files do not need fault-tolerance."-MS Q308417
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/