Re: [3/4] [PATCH]Diskdump - yet another crash dump function

[Christoph Hellwig]

> +/******************************** Disk dump ***********************************/
> +#if defined(CONFIG_DISKDUMP) || defined(CONFIG_DISKDUMP_MODULE)
> +#undef  add_timer
> +#define add_timer       diskdump_add_timer
> +#undef  del_timer_sync
> +#define del_timer_sync  diskdump_del_timer
> +#undef  del_timer
> +#define del_timer       diskdump_del_timer
> +#undef  mod_timer
> +#define mod_timer       diskdump_mod_timer
> +
> +#define tasklet_schedule        diskdump_tasklet_schedule
> +#endif

Yikes.  No way in hell we'll place code like this in drivers.  This needs
to be handled in common code.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/