Re: very low performance on SCSI disks if device node is in tmpfs

[Andrew Morton]

Linus Torvalds <torvalds@xxxxxxxx> wrote:
>
> On Tue, 25 May 2004, Andrew Morton wrote:
> >
> > We need to set file->f_ra _after_ calling blkdev_open(), when inode->i_mapping
> > points at the right thing.  And we need to get it from
> > inode->i_mapping->host->i_mapping too, which represents the underlying device.
> 
> Hmm.. Is f_mapping is guaranteed to be non-NULL?

Yes, we just did

        f->f_mapping = inode->i_mapping;

> At least for the O_DIRECT 
> case, we explicitly test for f_mapping being non-NULL, although that test 
> is quite possibly bogus. Maybe we should fix that too?

yup.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/