Re: EAGAIN in do_mmap_pgoff() [2.6.7-rc1]

[Chris Wright]

* Herbert Poetzl (herbert@xxxxxxxxxxxx) wrote:
> 
> just a short question:
> 
> is -EAGAIN here really intentional? wouldn't -ENOMEM be better?
> 
> mm/mmap.c ~780 do_mmap_pgoff()
> 
>         /* mlock MCL_FUTURE? */
>         if (vm_flags & VM_LOCKED) {
>                 unsigned long locked = mm->locked_vm << PAGE_SHIFT;
>                 locked += len;
>                 if (locked > current->rlim[RLIMIT_MEMLOCK].rlim_cur)
>                         return -EAGAIN;
>         }

Standards require this one:

[EAGAIN]
	[ML] The mapping could not be locked in memory, if required by
	     mlockall(), due to a lack of resources.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/