Re: 2.6.6-mm5

From: hch
Date: Sat May 22 2004 - 04:42:55 EST


On Sat, May 22, 2004 at 02:32:18AM -0700, Andrew Morton wrote:
> > code more readable sometimes) or stick a
>
> It uses a *ton* of anonymous unions.
>
> > #if (__GNUC__ < 3)
> > # error "This driver requires GCC 3.x"
> > #endif
>
> That breaks allfooconfig.

Well, the patch currently in -mm also breaks allmodconfig. Just not on
your arch or with a recent enough compiler, while with this it'll break
an all arches unless you have a recent enough compiler. And give the
driver isn't actually ppc specific that sounds like a really bad tradeoff.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/