[PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()

From: Arthur Othieno
Date: Fri May 21 2004 - 15:02:34 EST


Hi,

We're prematurely pampering the request queue before
checking whether it was indeed allocated successfully.

Against 2.6.6. Thanks.


floppy.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
+++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
@@ -4271,11 +4271,11 @@
goto out;

floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
- blk_queue_max_sectors(floppy_queue, 64);
if (!floppy_queue) {
err = -ENOMEM;
goto fail_queue;
}
+ blk_queue_max_sectors(floppy_queue, 64);

blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE,
floppy_find, NULL, NULL);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/