swsusp vs. pmdisk [was Re: swsusp: fix swsusp with intel-agp]

From: Pavel Machek
Date: Fri May 21 2004 - 06:26:10 EST


Hi!

> > > --- tmp/linux/arch/i386/mm/init.c 2004-05-20 23:08:05.000000000 +0200
> > > +++ linux/arch/i386/mm/init.c 2004-05-20 23:10:50.000000000 +0200
> > > @@ -331,6 +331,13 @@
> > > void zap_low_mappings (void)
> > > {
> > > int i;
> > > +
> > > +#ifdef CONFIG_SOFTWARE_SUSPEND
> >
> > Can you please define this for CONFIG_PM_DISK as well? Alternatively,
> > you can do the same as you did in cpu.c and define this for
> > CONFIG_PM.
>
> That would need few more parts to actually do something usefull on
> pmdisk, right? Lowlevel code needs to know how to switch.

What about killing pmdisk code, instead?

Its old, its not maintained any more, and it is unneccessary duplicity
of swsusp code.

Patrick, in middle of april you claimed you'll have something "by the
end of month". Can you either start looking after your code or give up
and let me remove it?
Pavel
--
934a471f20d6580d5aad759bf0d97ddc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/