Re: [PATCH] Remove bogus WARN_ON in futex_wait

From: Andi Kleen
Date: Thu May 20 2004 - 03:44:38 EST


On Thu, 20 May 2004 10:52:46 +1000
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> Which we've been trying to figure out. We return -EINTR in this case
> even though it's a lie. Don't know if it breaks anything, but I
> *really* want to know who the buggy waker is before pronouncing it
> harmless.

e.g. from ptrace, like Daniel said. I don't think it was from ptrace
in the case where I saw a report, but it shows that the WARN_ON is bogus.
If you really want to know what causes it you would need more debugging code
as Nick pointed out too. So, the WARN_ON in its current form
is known to trigger in a valid situation and not sufficient to find
possible problems. I would remove it.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/