Re: [PATCH] Fix 8139too ring size for dreamcast/embedded

[Jeff Garzik]

Paul Mundt wrote:
> Presently 2.6.6 backs out the CONFIG_8139_RXBUF_IDX in favor of using a
> hardcoded 8139_RXBUF_IDX (again). This seems to have been done due to
> some issues occuring with 8139_RXBUF_IDX == 3, however (as the Kconfig
> pointed out), we still need 8139_RXBUF_IDX == 1 in the CONFIG_SH_DREAMCAST
> case.
>
> The patch which made this change can be seen at:
>
> http://linux.bkbits.net:8080/linux-2.5/user=shemminger/cset@xxxxxxxxxxxxx?nav=!-|index.html|stats|!+|index.html|ChangeSet@-8w
>
> Before that, CONFIG_8139_RXBUF_IDX was set to 1 both in the CONFIG_SH_DREAMCAST
> and CONFIG_EMBEDDED cases. This patch adds that back into the current 8139too.

Patch applied to 2.6.x.


> Additionally, why remove the config option at all? Wouldn't it just be
> easier to drop the range from 0 - 3 to 0 - 2 until problems with a 64K ring
> size are resolved?

<shrug>  Mainly it was easier just to hardcode it in the driver.

I would not object to your suggestion of "0 - 2", however I tend to 
think that the current lack of option, with your patch applied, serves 
the user best:  the driver will always use the largest RX buffer 
possible for the hardware.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/