Re: RPC request reserved 0 but used 96

[Jens Axboe]

On Tue, May 18 2004, J. Bruce Fields wrote:
> On Sat, May 15, 2004 at 12:36:51PM +0200, Jens Axboe wrote:
> > 2.6.6-BK with shares exported sync show the same behaviour. I get:
> > 
> > RPC request reserved 0 but used 32900
> > RPC request reserved 0 but used 32900
> > RPC request reserved 0 but used 96
> 
> Does this end the messages?
> 
> --Bruce Fields
> 
> svc_recv may call svc_sock_release before rqstp->rq_res is initialized.
> 
>  net/sunrpc/svcsock.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff -puN net/sunrpc/svcsock.c~svc_reserve_debugging net/sunrpc/svcsock.c
> --- linux-2.6.6/net/sunrpc/svcsock.c~svc_reserve_debugging	2004-05-17 23:46:51.000000000 -0400
> +++ linux-2.6.6-bfields/net/sunrpc/svcsock.c	2004-05-17 23:50:54.000000000 -0400
> @@ -1255,6 +1255,7 @@ svc_recv(struct svc_serv *serv, struct s
>  
>  	/* No data, incomplete (TCP) read, or accept() */
>  	if (len == 0 || len == -EAGAIN) {
> +		rqstp->rq_res.len = 0;
>  		svc_sock_release(rqstp);
>  		return -EAGAIN;
>  	}

Seems to have fixed it, at least I haven't seen any messages of this
sort since applying the patch and switching back to nfs over tcp.
Thanks!

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/