Re: Linux 2.6.6 "IDE cache-flush at shutdown fixes"

[Andrew Morton]

Greg KH <greg@xxxxxxxxx> wrote:
>
> > Ho hum.  Greg, any preferences?  We can either:
> > 
> > a) Add a `restart' driver method and call that during reboot instead of
> >    ->shutdown, if the driver implements ->restart.  Otherwise call
> >    ->shutdown or
> > 
> > b) stick with the
> > 
> > 	if (system_state == SYSTEM_RESTART)
> > 		...
> > 
> >    thing in IDE and potentially a couple of other places?
> 
> I think we should stick with option b) for now, as we are already
> keeping this system state, right?

Yes, it's currently used in arch code which is otuside the driver model.

And the "current state of the entire system" maps comfortably onto a global
variable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/