Re: please apply the old patch from Georg Acher in 2.4 tree

[Pete Zaitcev]

On Mon, 26 Apr 2004 22:26:21 +0200
Sebastien Chaumat <schaumat@xxxxxxx> wrote:

>  I tried the patch from Georg Acher (posted 2001/08). It saved me from a
> lot of troubles with a brand news USB2 hub that refuses to take an
> address with  my nforce2 motherboard.
> 
> @@ -2177,18 +2178,31 @@
>  	dev->epmaxpacketin [0] = 8;
>  	dev->epmaxpacketout[0] = 8;
>  
> -	err = usb_set_address(dev);
> -	if (err < 0) {
> -		err("USB device not accepting new address=%d (error=%d)",
> -			dev->devnum, err);
> -		clear_bit(dev->devnum, &dev->bus->devmap.devicemap);
> -		dev->devnum = -1;
> -		return 1;
> -	}
> +	for(m=0;m<2;m++) {
> +		for(n=0;n<2;n++) {			
> +			err = usb_set_address(dev);
> +			if (err>=0)
> +				break;
> +			wait_ms(200);
> +		}

I see this was admitted to 2.6, with nice symbolic constants, too.
But before taking this, I would like someone to do this:
 1. posess a device which flakes like the above
 2. take the 2.6 version rediff and test it
 3. explain to me why he or she cannot just run 2.6 and be content

If Sebastien is willing to clear these hurdles I erected (and mentions the
vendor and device number of his hub), I'll think about it. But it would be
best if someone else came forward.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/