Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Adrian Bunk]

On Thu, May 13, 2004 at 04:03:15PM -0700, H. Peter Anvin wrote:
> Adrian Bunk wrote:
> >>
> >AFAIR, the -tiny tree already implements some kind of empty 
> >BUG/PAGE_BUG/WARN_ON macros.
> >
> >When optimizing for size that way, your suggestion would result in 
> >bigger code.
> >
> 
> ?!?!?!?!?!
> 
> If there are no side effects, my suggestion produces zero code.
> 
> >And after a quick view, I haven't seen any WARN_ON users in 2.6 that
> >seem to rely on side effects.
> 
> Then there should be no size difference, either.

Ah thanks, now I do understand it.

> 	-hpa

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/