Re: [4KSTACK][2.6.6] Stack overflow in radeonfb

[Randy.Dunlap]

On Thu, 13 May 2004 18:21:53 -0700 Andrew Morton <akpm@xxxxxxxx> wrote:

| Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
| >
| >  > 
| >  > int radeonfb_set_par(struct fb_info *info)
| >  > {
| >  >         struct radeonfb_info *rinfo = info->par;
| >  >         struct fb_var_screeninfo *mode = &info->var;
| >  >         struct radeon_regs newmode;
| >  >         
| >  > struct radeon_regs is huge: 2356 bytes
| >  > Quick fix (I'll test ASAP):
| > 
| >  Wow, this is evil indeed,
| 
| There should be some sort of prize ;)
| 
| There's a script out there somewhere which can autodetect this: build with
| frame pointers, parse the function preamble.  Does anyone have a copy
| handly?

Sure, it's at http://www.kernelnewbies.org/scripts/,
look for check-stack.sh, along with some other useful scripts.

| There's a `make buildcheck' target in -mm (from Arjan) into which we could
| integrate such a tool.  Although probably it should be a different make
| target.


--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/