Re: [PATCH] ib700wdt watchdog driver for 2.6.6

[Andrew Morton]

Patrice Bouchand <PBouchand@xxxxxxxxxxxxx> wrote:
>
> --- ./ib700wdt.c.orig   2004-05-10 08:57:54.000000000 +0200
>  +++ ./ib700wdt.c        2004-05-10 08:44:50.000000000 +0200
>  @@ -135,7 +135,7 @@
>   ibwdt_ping(void)
>   {
>          /* Write a watchdog value */
>  -       outb_p(wd_times[wd_margin], WDT_START);
>  +       outb_p(wd_margin, WDT_START);
>   }

The patch certainly looks sensible, but what about ibwdt_close() and
ibwdt_notify_sys()?  They're doing

		outb_p(wd_times[wd_margin], WDT_STOP);

which also seems peculiar.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/