Re: [PATCH] 2.6 I2C epson 8564 RTC chip
From: Greg KH
Date: Sat May 01 2004 - 00:54:06 EST
On Thu, Apr 29, 2004 at 02:02:50PM +0200, stefan.eletzhofer@xxxxxxxxxxxxx wrote:
> + if ( !buf || !client ) {
Can you clean up your exuberant use of spaces in 'if' statements, and
function calls? It's not the proper kernel style.
> +DONE:
Lowercase please
> + if ( ret ) {
> + if ( d ) kfree( d );
No need to check a pointer before sending it to kfree.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/