Re: reduce blk queue and I/O capability printk to KERN_DEBUG?

From: Matt Domsch
Date: Fri Apr 30 2004 - 16:30:59 EST


On Fri, Apr 30, 2004 at 11:13:43PM +0200, Jens Axboe wrote:
> It should just be deleted. As you note, it is a debug message. I
> originally added it so we would have some clues as to dma capability for
> bug reports. There never was any, the check can go :)

OK, please ack the below for Andrew then.


Remove blk: queue xxxx I/O limit xxxx messages printed by all block devices

This was a debug message and is no longer needed.

===== drivers/block/ll_rw_blk.c 1.244 vs edited =====
--- 1.244/drivers/block/ll_rw_blk.c Tue Apr 27 08:11:32 2004
+++ edited/drivers/block/ll_rw_blk.c Fri Apr 30 16:24:03 2004
@@ -280,17 +280,6 @@
} else
q->bounce_gfp = GFP_NOIO;

- /*
- * keep this for debugging for now...
- */
- if (dma_addr != BLK_BOUNCE_HIGH && q != last_q) {
- printk("blk: queue %p, ", q);
- if (dma_addr == BLK_BOUNCE_ANY)
- printk("no I/O memory limit\n");
- else
- printk("I/O limit %luMb (mask 0x%Lx)\n", mb, (long long) dma_addr);
- }
-
q->bounce_pfn = bounce_pfn;
last_q = q;
}



--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Attachment: pgp00000.pgp
Description: PGP signature