Re: BUG: might_sleep in /proc/swaps code

From: Tim Hockin
Date: Thu Apr 29 2004 - 14:23:58 EST


On Thu, Apr 29, 2004 at 03:03:09AM +0100, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
> OK, here comes. New semaphore protecting insertions/removals in the
> set of swap components + switch of ->start()/->stop() to the same
> semaphore [fixes deadlocks] + trivial cleanup of ->next().
>
> See if it works for you...

Well, it stops bitching about might_sleep(), so it solves the obvious
problems. I'm not in a position to comment about the other complexities of
swapfile.c, so I'll take it on faith that you got it right. :)

Thanks
Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/