Re: [PATCH] fix warning in arch/ppc/boot/simple/misc.c

[Tom Rini]

On Wed, Apr 28, 2004 at 03:14:38PM +0000, akpm@xxxxxxxx wrote:

> ChangeSet 1.1596.2.5, 2004/04/28 08:14:38-07:00, akpm@xxxxxxxx
> 
> 	[PATCH] fix warning in arch/ppc/boot/simple/misc.c
> 	
> 	From: Christoph Hellwig <hch@xxxxxx>
> 	
> 	asm-ppc/elf.h uses a pointer to struct task_struct without any
> 	forward-declaration.
> 	
> 	In file included from include/linux/elf.h:5,
> 	                 from arch/ppc/boot/simple/misc.c:20:
> 	include/asm/elf.h:102: warning: `struct task_struct' declared inside parameter list
> 	include/asm/elf.h:102: warning: its scope is only this definition or declaration, which is probably not what you want

This patch is redundant.  The correct fix, which got into -rc3, is to
drop <linux/elf.h> from the file in question.

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/