Re: netconsole hangs w/ alt-sysrq-t

[Matt Mackall]

On Wed, Apr 28, 2004 at 08:44:47AM -0400, Jeff Moyer wrote:
> ==> Regarding Re: netconsole hangs w/ alt-sysrq-t; Matt Mackall <mpm@xxxxxxxxxxx> adds:
> 
> mpm> On Thu, Apr 22, 2004 at 11:29:33AM -0400, Jeff Moyer wrote:
> >> If netconsole is enabled, and you hit Alt-Sysrq-t, then it will print a
> >> small amount of output to the console(s) and then hang the system.  In
> >> this case, I'm using the e100 driver, and we end up exhausting the
> >> available cbs.  Since we are in interrupt context, the driver's poll
> >> routine is never run, and we loop infinitely waiting for resources to
> >> free up that never will.  Kernel version is 2.6.5.
> 
> mpm> Can you try 2.6.6-rc2? It has a fix to congestion handling that should
> mpm> address this.
> 
> Is the attached patch the change you are referring to?  If so, I don't see
> how this would fix the problem.  I ended up deferring netpoll writes to
> process context, which has been working fine for me.  Have I missed
> something?

Well process context defeats the purpose. Ok, I've more closely read
your report and if I understand correctly, you're using the NAPI
version of e100? There's some magic NAPI bits in netpoll_poll that
might help here:

        if(trapped && np->dev->poll &&
           test_bit(__LINK_STATE_RX_SCHED, &np->dev->state))
                np->dev->poll(np->dev, &budget);

Perhaps we need to pull the trapped test out of there. Then with any
luck, dev->hard_start_xmit will return non-zero in netpoll_send_skb,
we'll call netpoll_poll to pump the card, and we'll be able to flush
it.

-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/