Re: [PATCH] Blacklist binary-only modules lying about their license

From: Helge Hafting
Date: Wed Apr 28 2004 - 06:30:03 EST


Marc Boucher wrote:

Hi Adam,

On Apr 27, 2004, at 1:25 PM, Adam Jaskiewicz wrote:


Actually, we also have no desire nor purpose to prevent tainting. The purpose
of the workaround is to avoid repetitive warning messages generated when
multiple modules belonging to a single logical "driver" are loaded (even when
a module is only probed but not used due to the hardware not being present).
Although the issue may sound trivial/harmless to people on the lkml, it was a
frequent cause of confusion for the average person.

Would it not be better to simply place a notice in the readme explaining what
the error messages mean, rather than working around the liscense checking
code? Educate the users, rather than fibbing.


Good idea. We will try to clarify the matter in the docs for the next release.
A lot of users don't read them though, so a proper fix remains necessary..

When distributing your module (with the license string fixed)
you may also distribute a kernel patch that disables the console message.
Better: you could change the logging level so the user only gets messages
in syslog and not on the console. A customer clueless enough to be confused
by the tainting message probably don't need those other console messages either.
Users with enough clue to want these messages may then turn them on again.

Helge Hafting

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/