Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

From: Pavel Machek
Date: Tue Apr 27 2004 - 18:18:10 EST


Hi!

> On Tue, 27 Apr 2004 23:52:36 +0200, Pavel Machek <pavel@xxxxxxx> wrote:
>
> >+#ifdef CONFIG_SOFTWARE_SUSPEND
> >+ {
> >+ extern char swsusp_pg_dir[PAGE_SIZE];
> >+ memcpy(swsusp_pg_dir, swapper_pg_dir, PAGE_SIZE);
> >+ }
> >+#endif
>
> Would you consider making that #ifdef CONFIG_PM, so that I could use it
> too without needing to patch it further? (I'm using
> CONFIG_SOFTWARE_SUSPEND2 if you prefer something more specific).
>

Well, swsusp_pg_dir is defined in kernel/power/cpu.c, so it is not as
easy as defining it CONFIG_PM.

What about make CONFIG_SOFTWARE_SUSPEND2 defining
CONFIG_SOFTWARE_SUSPEND, too? We want the merged, anyway...

Pavel
--
934a471f20d6580d5aad759bf0d97ddc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/