Re: [PATCH] lib/libcrc32c, revised 040427

From: Clay Haapala
Date: Tue Apr 27 2004 - 15:03:41 EST


On Tue, 27 Apr 2004, David S. Miller spake thusly:
> On Tue, 27 Apr 2004 14:46:35 -0500
> Clay Haapala <chaapala@xxxxxxxxx> wrote:
>
>> Attribute(pure) was used, so I changed the patch to use the define
>> in compiler.h, as you suggest. I will also change crc32.c, and
>> submit in a second patch. This is a patch against 2.6.5 sources.
>> I did not change the crypto patch, as this construct was not used
>> there.
>
> Please include linux/compiler.h if you're going to use it :-)
>
> Once you fix that, send it again and resend the crypto part to
> me as well and I'll apply everything for you.
>
> Thanks a lot for following up on this.

Uh .. I was prepared to terminally embarrassed by forgetting the
#include, but I *did* compile the files, with both GCC 3.3 and 2.96, so
compiler.h must be included by something else. Do you wish an
explicit include of compiler.h anyways? If so, no problem, let me know.
--
Clay Haapala (chaapala@xxxxxxxxx) Cisco Systems SRBU +1 763-398-1056
6450 Wedgwood Rd, Suite 130 Maple Grove MN 55311 PGP: C89240AD
"Oh, *that* Physics Prize. Well, I just substituted 'stupidity' for
'dark matter' in the equations, and it all came together."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/