sparc64 2.6.6-rc2-mm2 build busted: usb/core/hub.c hubstatus

From: Paul Jackson
Date: Mon Apr 26 2004 - 22:52:36 EST


Trying to build sparc64 as of 2.6.6-rc2-mm2, using the cross_compile
tools from http://developer.osdl.org/dev/plm/cross_compile/ (nice
tools - thanks!) fails for two reasons:

1) Broken drivers/char/drm/ffb_drv.c:

CC [M] drivers/char/drm/ffb_drv.o
In file included from drivers/char/drm/ffb_drv.c:336:
drivers/char/drm/drm_drv.h:547: error: `ffb_PCI_IDS' undeclared here (not in a function)
drivers/char/drm/drm_drv.h:547: error: initializer element is not constant
drivers/char/drm/drm_drv.h:547: error: (near initialization for `ffb_pciidlist[0]')
drivers/char/drm/ffb_drv.c:225: warning: `ffb_count_card_instances' defined but not used
make[3]: *** [drivers/char/drm/ffb_drv.o] Error 1

Andrew already reported this last week - something about missing PCI ID's.

2) An undefined 'hubstatus' variable in drivers/usb/core/hub.c:

CC drivers/usb/core/hub.o
drivers/usb/core/hub.c: In function `hub_port_connect_change':
drivers/usb/core/hub.c:1343: error: `hubstatus' undeclared (first use in this function)
drivers/usb/core/hub.c:1343: error: (Each undeclared identifier is reported only once
drivers/usb/core/hub.c:1343: error: for each function it appears in.)
make[3]: *** [drivers/usb/core/hub.o] Error 1

As a total shot in the dark, the following fixes the build (I've no clue
if it is the right fix):

===== drivers/usb/core/hub.c 1.93 vs edited =====
*** /tmp/hub.c-1.93-21850 Mon Apr 26 00:44:33 2004
--- drivers/usb/core/hub.c Mon Apr 26 20:44:58 2004
*************** static void hub_port_connect_change(stru
*** 1340,1346 ****
dev_dbg(&dev->dev, "get status %d ?\n", status);
continue;
}
! cpu_to_le16s(&hubstatus);
if ((devstat & (1 << USB_DEVICE_SELF_POWERED)) == 0) {
dev_err(&dev->dev,
"can't connect bus-powered hub "
--- 1340,1346 ----
dev_dbg(&dev->dev, "get status %d ?\n", status);
continue;
}
! cpu_to_le16s(&devstat);
if ((devstat & (1 << USB_DEVICE_SELF_POWERED)) == 0) {
dev_err(&dev->dev,
"can't connect bus-powered hub "


--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/