Re: [PATCH 6/11] nfsacl-lazy-alloc

From: Trond Myklebust
Date: Mon Apr 26 2004 - 15:39:52 EST


On Mon, 2004-04-26 at 06:28, Andreas Gruenbacher wrote:
> Allow to allocate pages in the receive buffers lazily
>
> Patch from Olaf Kirch <okir@xxxxxxx>: Replies to the GETACL remote
> procedure call can become quite big, yet in the common case replies will
> be very small. This patch checks of argument pages have already been
> allocated, and allocates pages up to the maximum length of the xdr_buf
> when this is not the case.

AFAICS, there is nothing to stop xdr_partial_copy_from_skb() from
writing beyond the end of xdr->pages[]. How do you propose to prevent
this?

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/