Re: Bug#234976: kernel-source-2.6.4: Software Suspend doesn't work

From: Pavel Machek
Date: Mon Apr 26 2004 - 09:17:06 EST


Hi!

> >>come up with a more nuanced test? Better still, though, we should just
> >>get
> >>proper AGP support for suspending and resuming in.
> >
> >It's got nothing to do with AGP. This is a flaw in the swsusp code.
> >It can be triggered by anything that plays with page attributes.
>
> Not so much a flaw in the suspend code as something that needs to be dealt
> with: it's not a bug for pages to have protection, and its not a bug for
> us to need it temporarily removed in order to do the copyback. We just
> need the support in the drivers to achieve that. When we have it (as we do
> in some cases in 2.4), all is well.

No, Herbert is right here. This *is* swsusp fault. Swsusp assumes 4MB
tables which is not guaranteed even on PSE machines.
Pavel
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/