Re: [2.4.26 Patch] Blue line in nVidia framebuffer (rivafb)

[James Simmons]

Its in 2.6.X as well. Applied patch.


On Wed, 14 Apr 2004, Byron Stanoszek wrote:

> This patch fixes a regression since Linux 2.4.21. There is an off-by-one error
> with the vertical-blank register in the riva framebuffer driver. The error
> makes a persistent scan line (normally blue) appear on the top of the screen.
> 
> Marcelo, please include this patch in the next -pre series.
> 
> Thanks,
>  Byron
> 
> 
> --- linux-2.4.26/drivers/video/riva/fbdev.bak	Wed Apr 14 11:45:26 2004
> +++ linux-2.4.26/drivers/video/riva/fbdev.c	Wed Apr 14 14:15:22 2004
> @@ -952,7 +952,7 @@
>  	newmode.crtc[0x12] = Set8Bits (vDisplay);
>  	newmode.crtc[0x13] = ((width / 8) * ((bpp + 1) / 8)) & 0xFF;
>  	newmode.crtc[0x15] = Set8Bits (vBlankStart);
> -	newmode.crtc[0x16] = Set8Bits (vBlankEnd);
> +	newmode.crtc[0x16] = Set8Bits (vBlankEnd + 1);
> 
>  	newmode.ext.bpp = bpp;
>  	newmode.ext.width = width;
> 
> 
> 
> --
> Byron Stanoszek                         Ph: (330) 644-3059
> Systems Programmer                      Fax: (330) 644-8110
> Commercial Timesharing Inc.             Email: byron@xxxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/