Re: [PATCH] 32-bit process accounting

From: Tim Schmielau
Date: Fri Apr 23 2004 - 12:01:37 EST


On Fri, 23 Apr 2004, Felipe W Damasio wrote:

@@ -41,8 +41,8 @@
> * No binary format break with 2.0 - but when we hit 32bit uid we'll
> * have to bite one
> */
> - __u16 ac_uid; /* Accounting Real User ID
> */
> - __u16 ac_gid; /* Accounting Real Group ID */
> + uid_t ac_uid; /* Accounting Real User ID */
> + gid_t ac_gid; /* Accounting Real Group ID */
> __u16 ac_tty; /* Accounting Control Terminal */
> __u32 ac_btime; /* Accounting Process Creation Time */
> comp_t ac_utime; /* Accounting User Time */

This breaks binary compatibility, so you should change the comment as well.

Seriously, it's of course better not to break binary compatibility, as in
this patch
http://www.lib.uaa.alaska.edu/linux-kernel/archive/2004-Week-11/1337.html

I have to admit that things are moving a bit slow as I had no spare time
to push this patch. Will try to do that in the next week.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/