RE: [patch 1/3] efivars driver update and move

From: Tolentino, Matthew E
Date: Thu Apr 22 2004 - 12:16:35 EST


> I like these changes.

Thanks!

> I did notice that the new drivers/.../efivars.c is not identical to
> the old arch/ia64/kernel/efivars.c (the hints to emacs were removed).
> I like the emacs hint removal, but didn't review patch for any other
> differences.

Right, it's been fully converted to sysfs. Just for reference, the
resultant sysfs tree looks something like:

/sys |
...
|-firmware
|-efi
|-systab
|-vars
|- BootNext-xxxx-xxx-x-x-x-x *
|-attributes
|-data
|-guid
|-raw_var
|-size
|- BootCurrent-xxxxxx-x-x-x-x *
|- ConOut-xxxx-x-x-x-x-x-x-*
...
|- del_var
|- new_var

where xxxx-x-x-x-x-x is the GUID.

> Any plans to consolidate other bits from efi.c? There are a number
> of things there that look like they could be shared:

Yes, I plan to consolidate as much of the common code as possible soon.


matt

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/