Re: [Patch 0 of 17] cpumask v4 - bitmap and cpumask cleanup

From: Joe Korty
Date: Thu Apr 22 2004 - 11:26:58 EST


Hi Paul,
This patch gets the new bitmap stuff to compile and pass a boot-test
on Opteron.

I especially like the cleaned-up, orthogonal API and your addition of
the missing bitmap_andnot() function. Good work!

Regards,
Joe
"Money can buy bandwidth, but latency is forever" -- John Mashey


diff -ura 2.6.5-pj/arch/x86_64/kernel/smpboot.c 2.6.5-pj2/arch/x86_64/kernel/smpboot.c
--- 2.6.5-pj/arch/x86_64/kernel/smpboot.c 2004-04-03 22:38:26.000000000 -0500
+++ 2.6.5-pj2/arch/x86_64/kernel/smpboot.c 2004-04-22 12:06:02.209264270 -0400
@@ -827,7 +827,7 @@
if (apicid == boot_cpu_id)
continue;

- if (!cpu_isset(apicid, phys_cpu_present_map))
+ if (!physid_isset(apicid, phys_cpu_present_map))
continue;
if ((max_cpus >= 0) && (max_cpus <= cpucount+1))
continue;
diff -ura 2.6.5-pj/include/asm-x86_64/smp.h 2.6.5-pj2/include/asm-x86_64/smp.h
--- 2.6.5-pj/include/asm-x86_64/smp.h 2004-04-22 12:19:58.665010667 -0400
+++ 2.6.5-pj2/include/asm-x86_64/smp.h 2004-04-22 11:43:49.190316603 -0400
@@ -60,7 +60,6 @@

extern cpumask_t cpu_callout_map;
#define cpu_possible_map cpu_callout_map
-#define cpu_online(cpu) cpu_isset(cpu, cpu_online_map)

static inline int num_booting_cpus(void)
{
@@ -85,7 +84,6 @@

#define safe_smp_processor_id() (disable_apic ? 0 : x86_apicid_to_cpu[hard_smp_processor_id()])

-#define cpu_online(cpu) cpu_isset(cpu, cpu_online_map)
#endif /* !ASSEMBLY */

#define NO_PROC_ID 0xFF /* No processor magic marker */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/