Re: [PATCH] s390 (9/9): no timer interrupts in idle.

From: Dipankar Sarma
Date: Wed Apr 21 2004 - 15:47:58 EST


On Wed, Apr 21, 2004 at 06:37:29PM +0200, Martin Schwidefsky wrote:
> > > This would mean that all other arches need to do the above three
> > > statements in rcu_start_batch. If this is acceptable we certainly
> > > can introduce a global idle_cpu_mask. Where? sched.c?
> >
> > My hope was gcc would actually optimize it away if it was a CPP constant
> > instead of a variable.
>
> Now I got it. You want to introduce a generic idle_cpu_mask which is a
> #define to CPU_MASK_NONE and only an exploiter would use a real variable.
> This is just a matter of test. I'll give it a try.

I think CPU_MASK_NONE can be used only for assignments. You need
to actually declare a generic idle_cpu_mask and set it to CPU_MASK_NONE
for all other archs. Of course, then the compiler will not be able
to optimize it out :)

Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/