Re: [PATCH 5/15] New set of input patches: lkkbd simplify checks

[Jan-Benedict Glaw]

On Wed, 2004-04-21 00:53:07 -0500, Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
wrote in message <200404210053.09166.dtor_core@xxxxxxxxxxxxx>:
> --- a/drivers/input/keyboard/lkkbd.c	Tue Apr 20 23:01:41 2004
> +++ b/drivers/input/keyboard/lkkbd.c	Tue Apr 20 23:01:41 2004
> @@ -527,9 +527,7 @@
>  
>  	if ((serio->type & SERIO_TYPE) != SERIO_RS232)
>  		return;
> -	if (!(serio->type & SERIO_PROTO))
> -		return;
> -	if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_LKKBD)
> +	if ((serio->type & SERIO_PROTO) != SERIO_LKKBD)
>  		return;
>  
>  	if (!(lk = kmalloc (sizeof (struct lkkbd), GFP_KERNEL)))

Looks good. I'll take this patch inty my "master" version.

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature