Re: [CHECKER] Probable security holes in 2.6.5

[Chris Wright]

* Andrea Arcangeli (andrea@xxxxxxx) wrote:
> On Fri, Apr 16, 2004 at 11:54:06AM -0700, Chris Wright wrote:
> > +	if (mc.idx >= dma->buf_count)
> > +		return -EINVAL;
> > +
> >  	i810_dma_dispatch_mc(dev, dma->buflist[mc.idx], mc.used,
> >  		mc.last_render );
> 
> this is wrong, idx is signed, so you've to check for negative values
> too. Credit for noticing this doesn't belong to me though.

Yes, you are right.  I thought I had specifically checked and found it
unsigned.  Thanks for catching that.

> Could you just in case review the other fixes too for other potential
> errors like this? thanks.

Yes, I'll do a double check.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/