[PATCH] drivers/ide/Kconfig: make PDC4030 VLB IDE support dependent on X86

From: Bartlomiej Zolnierkiewicz
Date: Tue Apr 20 2004 - 18:12:34 EST



Also add FIXME about improper ide_init_hwif_ports() usage to pdc4030.c.

linux-2.6.6-rc1-bk5-bzolnier/drivers/ide/Kconfig | 2 +-
linux-2.6.6-rc1-bk5-bzolnier/drivers/ide/legacy/pdc4030.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff -puN drivers/ide/Kconfig~pdc4030_x86 drivers/ide/Kconfig
--- linux-2.6.6-rc1-bk5/drivers/ide/Kconfig~pdc4030_x86 2004-04-20 22:05:39.977020112 +0200
+++ linux-2.6.6-rc1-bk5-bzolnier/drivers/ide/Kconfig 2004-04-20 22:06:45.065125216 +0200
@@ -1062,7 +1062,7 @@ config BLK_DEV_HT6560B

config BLK_DEV_PDC4030
tristate "PROMISE DC4030 support (EXPERIMENTAL)"
- depends on BLK_DEV_IDEDISK && EXPERIMENTAL
+ depends on X86 && BLK_DEV_IDEDISK && EXPERIMENTAL
help
This driver provides support for the secondary IDE interface and
cache of the original Promise IDE chipsets, e.g. DC4030 and DC5030.
diff -puN drivers/ide/legacy/pdc4030.c~pdc4030_x86 drivers/ide/legacy/pdc4030.c
--- linux-2.6.6-rc1-bk5/drivers/ide/legacy/pdc4030.c~pdc4030_x86 2004-04-20 22:05:44.844280176 +0200
+++ linux-2.6.6-rc1-bk5-bzolnier/drivers/ide/legacy/pdc4030.c 2004-04-20 22:08:09.484291552 +0200
@@ -242,6 +242,7 @@ int __init setup_pdc4030(ide_hwif_t *hwi
#ifdef DEBUG
printk(KERN_DEBUG "pdc4030: Shifting i/f %d values to i/f %d\n",i-1,i);
#endif /* DEBUG */
+ /* FIXME: this screws already used hwifs */
ide_init_hwif_ports(&h->hw, (h-1)->io_ports[IDE_DATA_OFFSET], 0, NULL);
memcpy(h->io_ports, h->hw.io_ports, sizeof(h->io_ports));
h->noprobe = (h-1)->noprobe;

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/