Re: [PATCH] tg3 driver - make use of binary-only firmware optional

[Jeff Garzik]

Andreas Jochens wrote:
> On 04-Apr-18 18:08, David S. Miller wrote:
>
> > However, that in no way means that Jeff and myself have to split
> > the firmware out of the driver either.  In fact, I do not want to
> > as I like keeping all of the network drivers I write in single
> > foo.c and foo.h files.
>
>
> Would the patch be acceptable if the firmware parts were kept in tg3.c
> as they are now but #ifdef'd out when CONFIG_TIGON3_FIRMWARE is not set?
>
> At least this would make it clear that the driver is usable even without 
> the firmware. Or is there perhaps any technical problem which might 
> occur when firmware loading is optionally disabled as indicated below?
>
> Thank you for your attention.


It's still a patch for more political purposes than technical ones.

See my other message -- when the Just Works(tm) value is high enough, we 
can use the kernel firmware loader, and the firmware will be outside the 
driver source code.

But since using the firmware loader _right now_ would kill 
loader-unaware situations like the installer or "kickstart", it's not 
feasible.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/