Re: [PATCH 1/3] lockfs - vfs bits

From: Chris Mason
Date: Mon Apr 19 2004 - 08:47:50 EST


On Sat, 2004-04-17 at 19:30, Andrew Morton wrote:
> Christoph Hellwig <hch@xxxxxx> wrote:
> >
> > These are the generic lockfs bits. Basically it takes the XFS freezing
> > statemachine into the VFS. It's all behind the kernel-doc documented
> > freeze_bdev and thaw_bdev interfaces.
>
> Do we expect to see snapshotting patches for other filesystems arise as a
> result of this?

Reiserfs needs this one liner:

reiserfs_write_super_lockfs() is supposed to wait for the transaction
to commit.

Index: linux.t/fs/reiserfs/super.c
===================================================================
--- linux.t.orig/fs/reiserfs/super.c 2004-04-01 08:54:54.000000000 -0500
+++ linux.t/fs/reiserfs/super.c 2004-04-01 09:08:45.000000000 -0500
@@ -88,7 +88,7 @@ static void reiserfs_write_super_lockfs
reiserfs_prepare_for_journal(s, SB_BUFFER_WITH_SB(s), 1);
journal_mark_dirty(&th, s, SB_BUFFER_WITH_SB (s));
reiserfs_block_writes(&th) ;
- journal_end(&th, s, 1) ;
+ journal_end_sync(&th, s, 1) ;
}
s->s_dirt = 0;
reiserfs_write_unlock(s);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/