Re: [PATCH] Fix unix module

From: Rusty Russell
Date: Sun Apr 18 2004 - 05:09:31 EST


On Sun, 2004-04-18 at 18:01, Russell King wrote:
> On Sun, Apr 18, 2004 at 03:32:42PM +1000, Rusty Russell wrote:
> > The compiler #define's unix to 1: we use -DKBUILD_MODNAME=unix. We
> > used to #undef unix at the top of af_unix.c, but now the name is
> > inserted by modpost, that doesn't help.
>
> Do we depend on this preprocessor symbol anywhere? If not, adding
> -Uunix to the global CFLAGS would prevent future "accidents".

I don't really mind which way it's done, but this was the direct
translation of the previous fix, so required less testing.

Hopefully noone will ever call their module "linux", "i386" or
"__OPTIMIZE__" 8)

Cheers,
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/