Re: modprobe 3c509 segfaults
From: Andrew Morton
Date: Sat Apr 17 2004 - 12:59:01 EST
Kimmo Sundqvist <musher@xxxxxxxx> wrote:
>
> Apr 17 01:38:02 shadowgate EIP: 0060:[<c58c2789>] Not tainted
> Apr 17 01:38:02 shadowgate EFLAGS: 00010202
> Apr 17 01:38:02 shadowgate EIP is at el3_init_module+0x49/0x8c [3c509]
> Apr 17 01:38:02 shadowgate eax: 00000000 ebx: c0297d30 ecx: c0297e9c
> edx: 00000005
> Apr 17 01:38:02 shadowgate esi: c3c8e000 edi: c58ec980 ebp: c0297d18
> esp: c3c8ffac
> Apr 17 01:38:02 shadowgate ds: 007b es: 007b ss: 0068
> Apr 17 01:38:02 shadowgate Process modprobe (pid: 2503, threadinfo=c3c8e000
> task=c1124080)
> Apr 17 01:38:02 shadowgate Stack: c012ed98 0806a5c0 00004487 08057100 c3c8e000
> c0108d37 0806a5c0 00004487
> Apr 17 01:38:02 shadowgate 08057110 00004487 08057100 bffffa08 00000080
> 0000007b 0000007b 00000080
> Apr 17 01:38:02 shadowgate 400e328e 00000073 00000246 bffff9dc 0000007b
> Apr 17 01:38:02 shadowgate Call Trace:
> Apr 17 01:38:02 shadowgate [<c012ed98>] sys_init_module+0xf8/0x220
> Apr 17 01:38:02 shadowgate [<c0108d37>] syscall_call+0x7/0xb
Seems that we used to unconditionally link the device into the
el3_root_devchain in el3_common_init(), but that was removed, and we now
conditionally link it, denendent upon sone ifdefs which you presumably have
not set.
Does this fix it up?
---
25-akpm/drivers/net/3c509.c | 2 --
1 files changed, 2 deletions(-)
diff -puN drivers/net/3c509.c~3c509-oops-fix drivers/net/3c509.c
--- 25/drivers/net/3c509.c~3c509-oops-fix 2004-04-17 10:53:37.298867104 -0700
+++ 25-akpm/drivers/net/3c509.c 2004-04-17 10:54:01.864132616 -0700
@@ -595,10 +595,8 @@ no_pnp:
#endif
el3_cards++;
-#if !defined(__ISAPNP__) || defined(CONFIG_X86_PC9800)
lp->next_dev = el3_root_dev;
el3_root_dev = dev;
-#endif
return 0;
out1:
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/