Re: fix notify_change() potential null dereference.

From: Christoph Hellwig
Date: Fri Apr 16 2004 - 17:35:12 EST


On Fri, Apr 16, 2004 at 10:37:43PM +0100, Dave Jones wrote:
>
> --- linux-2.6.5/fs/attr.c~ 2004-04-16 22:36:00.000000000 +0100
> +++ linux-2.6.5/fs/attr.c 2004-04-16 22:36:37.000000000 +0100
> @@ -130,7 +130,7 @@
> int notify_change(struct dentry * dentry, struct iattr * attr)
> {
> struct inode *inode = dentry->d_inode;
> - mode_t mode = inode->i_mode;
> + mode_t mode;

Passing a NULL argument to notify_change() is invalid.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/