Re: RFC: COW for hugepages

[Andrew Morton]

Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> 
> > Implementing this for ppc64 only is just wrong. Before you do this 
> > I would suggest to factor out the common code in the various hugetlbpage
> > implementations and then implement it in common code.
> 
> Have you actually looked at it and how huge pages are implemented
> on the various architectures ?
> 
> Honestly, I don't think we have any common abstraction on things
> like hugepte's etc... actually, archs aren't even required to use
> PTEs at all.
> 
> I don't see how we can make that code arch-neutral, at least not
> without a major redesign of the whole large pages mecanism.

I don't see much in the COW code which is ppc64-specific.  All the hardware
needs to do is to provide a way to make the big pages readonly.  With a bit
of an abstraction for the TLB manipulation in there it should be pretty
straightforward.

Certainly worth the attempt, no?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/