Re: RFC: COW for hugepages

From: Andi Kleen
Date: Wed Apr 07 2004 - 09:52:30 EST


On Thu, 8 Apr 2004 00:27:48 +1000
Anton Blanchard <anton@xxxxxxxxx> wrote:

>
> > Implementing this for ppc64 only is just wrong. Before you do this
> > I would suggest to factor out the common code in the various hugetlbpage
> > implementations and then implement it in common code.
>
> I could say a similar thing about your i386 specific largepage modifications
> in the NUMA api :)

All they did was to modify the code to lazy faulting. That is architecture specific

(and add the mpol code, but that was pretty minor)

COW is a different thing though.

>
> We should probably look at making lots of the arch specific hugetlb code
> common but im not sure we want that to become a prerequisite for merging
> NUMA API and hugepage COW.

That would just make the merging later harder. Making it common first and then
adding features would be better.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/