Re: 2.6.5-rc3: cat /proc/ide/hpt366 kills disk on second channel

From: John Stoffel
Date: Tue Apr 06 2004 - 13:38:18 EST



Thanks Bart,

I'm compiling 2.6.3 right now with that patch and I'll let you know
how it goes.

Could it be that someone just mixed up the outb() and meant to use
inb() in that section? I don't know the driver (or much kernel stuff)
in any detail. Hmm... looking at it, it seems like they expect that
reading the cable info then requires your to mask some bits off and
then re-read to get the other port. Whee...

I wonder how hard it would be to put in locking there. I'll let you
know ASAP how well this fix works in the short run.

Should I try to look through all the various *_get_info() routines to
see if any others are doing outb() calls as well?

Heh... just looking at the code for aec62xx.c, should we be really
using pci_read_config_byte() instead of inb() in the hpt366.c code?

John

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/