[PATCH] isicom error path

[Geert Uytterhoeven]

Variable error is not initialized, but printed if tty_unregister_driver() fails

--- linux-2.6.5/drivers/char/isicom.c.orig	2004-03-04 11:30:38.000000000 +0100
+++ linux-2.6.5/drivers/char/isicom.c	2004-04-02 10:59:33.000000000 +0200
@@ -1649,8 +1649,8 @@

 static void unregister_drivers(void)
 {
-	int error;
-	if (tty_unregister_driver(isicom_normal))
+	int error = tty_unregister_driver(isicom_normal);
+	if (error)
 		printk(KERN_DEBUG "ISICOM: couldn't unregister normal driver error=%d.\n",error);
 	put_tty_driver(isicom_normal);
 }

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/