Re: swsusp update: supports discontingmem/highmem

From: Andrew Morton
Date: Mon Apr 05 2004 - 17:43:45 EST


Pavel Machek <pavel@xxxxxx> wrote:
>
> It makes swsusp behave correctly
> w.r.t. discontingmem, and adds highmem handling

Some of those ENOMEM panics in save_highmem_zone() look like they might
need proper handling instead?

The 256 byte automatic array in read_swapfiles() may bring you a visit from
the stack space police, although I don't think it's really a problem. 256
bytes for a pathname may be a bit excessive though.

Please send me an update patch sometime which makes all the new code go
away again if !CONFIG_HIGHMEM.

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/